[SPARK-30863][SQL] Distinguish Cast and AnsiCast in toString #27608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
cloud-fan
reviewed
Feb 17, 2020
|
|
||
| override def toString: String = s"cast($child as ${dataType.simpleString})" | ||
| override def toString: String = { | ||
| val ansi = if (ansiEnabled) "ansi" else "" |
|
Test build #118592 has finished for PR 27608 at commit
|
|
Test build #118588 has finished for PR 27608 at commit
|
Member
|
For better commit logs, could you put a simple example plan output before/after this pr in the description above? |
Member
Author
Added. Thanks! |
cloud-fan
approved these changes
Feb 18, 2020
Contributor
|
@Ngone51 can we have a JIRA? It touches many files and worth a JIRA. |
Ngone51
changed the title
Member
Author
Done. |
|
Test build #118607 has finished for PR 27608 at commit
|
maropu
approved these changes
Feb 18, 2020
|
|
||
| override def toString: String = s"cast($child as ${dataType.simpleString})" | ||
| override def toString: String = { | ||
| val ansi = if (ansiEnabled) "ansi_" else "" |
Member
There was a problem hiding this comment.
I think it should be "ansiCast" or "ANSICast" instead of "ansi_cast"
Contributor
There was a problem hiding this comment.
This follows the existing SQL function naming convention, e.g. FromUTCTimestamp.prettyName is from_utc_timestamp
Member
There was a problem hiding this comment.
But the string of newInstance is newInstance($cls) ..
Contributor
There was a problem hiding this comment.
NewInstance is not really a SQL function/operator...
Member
There was a problem hiding this comment.
I see. It is the first expression the overrides toString with 2 words in IDE...haha
Contributor
|
thanks, merging to master/3.0! |
Member
Author
|
Thanks all!! |
cloud-fan
pushed a commit
that referenced
this pull request
Feb 18, 2020
### What changes were proposed in this pull request?
Prefix by `ansi_` in `toString` if it's a `AnsiCast` or ansi enabled `Cast`.
E.g. run `spark.sql("select cast('51' as int)").queryExecution.analyzed` under ansi mode.
Before this PR:
```
Project [cast(51 as int) AS CAST(51 AS INT)#0]
+- OneRowRelation
```
After this PR:
```
Project [ansi_cast(51 as int) AS CAST(51 AS INT)#0]
+- OneRowRelation
```
### Why are the changes needed?
This is useful while comparing `LogicalPlan`s literally.
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Pass Jenkins.
Closes #27608 from Ngone51/ansi_cast_tostring.
Authored-by: yi.wu <yi.wu@databricks.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit 643a480)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
### What changes were proposed in this pull request?
Prefix by `ansi_` in `toString` if it's a `AnsiCast` or ansi enabled `Cast`.
E.g. run `spark.sql("select cast('51' as int)").queryExecution.analyzed` under ansi mode.
Before this PR:
```
Project [cast(51 as int) AS CAST(51 AS INT)#0]
+- OneRowRelation
```
After this PR:
```
Project [ansi_cast(51 as int) AS CAST(51 AS INT)#0]
+- OneRowRelation
```
### Why are the changes needed?
This is useful while comparing `LogicalPlan`s literally.
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Pass Jenkins.
Closes apache#27608 from Ngone51/ansi_cast_tostring.
Authored-by: yi.wu <yi.wu@databricks.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
gengliangwang
added a commit
that referenced
this pull request
Feb 18, 2022
…st" under ANSI mode ### What changes were proposed in this pull request? Change Cast.toString as "cast" instead of "ansi_cast" under ANSI mode. This is to restore the behavior before #27608 ### Why are the changes needed? 1. There is no such a function "ansi_cast" in Spark SQL 2. Add/Divide/.. has different behavior under ANSI mode as well, but they don't have this special string representation. 3. As we are setting up new Github job for ANSI mode, this can avoid test failures from TPCDS plan stability test suites ### Does this PR introduce _any_ user-facing change? Yes but quite minor, the string output of `Cast` under ANSI mode becomes "cast" instead of "ansi_cast" again. ### How was this patch tested? Existing UT Closes #35570 from gengliangwang/revert-SPARK-30863. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Prefix by
ansi_intoStringif it's aAnsiCastor ansi enabledCast.E.g. run
spark.sql("select cast('51' as int)").queryExecution.analyzedunder ansi mode.Before this PR:
After this PR:
Why are the changes needed?
This is useful while comparing
LogicalPlans literally.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass Jenkins.